Commit 8ff396fe authored Jan 17, 2019 by Peter Chen Committed by Greg Kroah-Hartman Jan 18, 2019

usb: chipidea: fix static checker warning for NULL pointer



During the static checker, "data->usbmisc_data" may be NULL.
Fix it by adding this pointer judgement before using.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a817c59e

drivers/usb/chipidea/ci_hdrc_imx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -316,7 +316,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
		if (IS_ERR(data->usbmisc_data))
		return PTR_ERR(data->usbmisc_data);

		if (of_usb_get_phy_mode(dev->of_node) == USBPHY_INTERFACE_MODE_HSIC) {
		if ((of_usb_get_phy_mode(dev->of_node) == USBPHY_INTERFACE_MODE_HSIC)
		&& data->usbmisc_data) {
		pdata.flags \|= CI_HDRC_IMX_IS_HSIC;
		data->usbmisc_data->hsic = 1;
		data->pinctrl = devm_pinctrl_get(dev);

Admin message