Commit 8fe78048 authored Aug 06, 2014 by David Rientjes Committed by Linus Torvalds Aug 06, 2014

mm, thp: restructure thp avoidance of light synchronous migration



__GFP_NO_KSWAPD, once the way to determine if an allocation was for thp
or not, has gained more users.  Their use is not necessarily wrong, they
are trying to do a memory allocation that can easily fail without
disturbing kswapd, so the bit has gained additional usecases.

This restructures the check to determine whether MIGRATE_SYNC_LIGHT
should be used for memory compaction in the page allocator.  Rather than
testing solely for __GFP_NO_KSWAPD, test for all bits that must be set
for thp allocations.

This also moves the check to be done only after the page allocator is
aborted for deferred or contended memory compaction since setting
migration_mode for this case is pointless.

Signed-off-by: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e972a070

mm/page_alloc.c

+9 −8

Original line number	Diff line number	Diff line
		@@ -2638,14 +2638,6 @@ rebalance:
		if (page)
		goto got_pg;

		/*
		* It can become very expensive to allocate transparent hugepages at
		* fault, so use asynchronous memory compaction for THP unless it is
		* khugepaged trying to collapse.
		*/
		if (!(gfp_mask & __GFP_NO_KSWAPD) \|\| (current->flags & PF_KTHREAD))
		migration_mode = MIGRATE_SYNC_LIGHT;

		/*
		* If compaction is deferred for high-order allocations, it is because
		* sync compaction recently failed. In this is the case and the caller
		@@ -2656,6 +2648,15 @@ rebalance:
		(gfp_mask & __GFP_NO_KSWAPD))
		goto nopage;

		/*
		* It can become very expensive to allocate transparent hugepages at
		* fault, so use asynchronous memory compaction for THP unless it is
		* khugepaged trying to collapse.
		*/
		if ((gfp_mask & GFP_TRANSHUGE) != GFP_TRANSHUGE \|\|
		(current->flags & PF_KTHREAD))
		migration_mode = MIGRATE_SYNC_LIGHT;

		/* Try direct reclaim and then allocating */
		page = __alloc_pages_direct_reclaim(gfp_mask, order,
		zonelist, high_zoneidx,

Admin message