Commit 8fd8cbfe authored Oct 18, 2018 by Dan Carpenter Committed by Borislav Petkov Nov 06, 2018

EDAC, qcom_edac: Remove irq_handled local variable



irq_handled isn't initialized to false on function entry. However, it is
not really needed and the IRQ handler return value can be set directly
instead.

 [ bp: rewrite commit message. ]

Fixes: 27450653 ("drivers: edac: Add EDAC driver support for QCOM SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
CC: Channagoud Kadabi <ckadabi@codeaurora.org>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
CC: kernel-janitors@vger.kernel.org
CC: linux-arm-msm@vger.kernel.org
CC: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20181018141522.rywdvjmlpk4ticiw@kili.mountain

parent 1a81361f

drivers/edac/qcom_edac.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -292,7 +292,6 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
		struct llcc_drv_data *drv = edac_dev_ctl->pvt_info;
		irqreturn_t irq_rc = IRQ_NONE;
		u32 drp_error, trp_error, i;
		bool irq_handled;
		int ret;

		/* Iterate over the banks and look for Tag RAM or Data RAM errors */
		@@ -311,7 +310,7 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
		ret = dump_syn_reg(edev_ctl, LLCC_DRAM_UE, i);
		}
		if (!ret)
		irq_handled = true;
		irq_rc = IRQ_HANDLED;

		ret = regmap_read(drv->regmap,
		drv->offsets[i] + TRP_INTERRUPT_0_STATUS,
		@@ -327,11 +326,8 @@ llcc_ecc_irq_handler(int irq, void *edev_ctl)
		ret = dump_syn_reg(edev_ctl, LLCC_TRAM_UE, i);
		}
		if (!ret)
		irq_handled = true;
		}

		if (irq_handled)
		irq_rc = IRQ_HANDLED;
		}

		return irq_rc;
		}

Admin message