Commit 8fd3a98f authored Jan 24, 2007 by David Teigland Committed by Steven Whitehouse Feb 05, 2007

[DLM] saved dlm message can be dropped

dlm_receive_message() returns 0 instead of returning 'error'. What would
happen is that process_requestqueue would take a saved message off the
requestqueue and call receive_message on it. receive_message would then
see that recovery had been aborted, set error to EINTR, and 'goto out',
expecting that the error would be returned. Instead, 0 was always
returned, so process_requestqueue would think that the message had been
processed and delete it instead of saving it to process next time. This
means the message (usually an unlock in my tests) would be lost.

Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent f1f1c1cc

fs/dlm/lock.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3018,7 +3018,7 @@ int dlm_receive_message(struct dlm_header *hd, int nodeid, int recovery)
		{
		struct dlm_message ms = (struct dlm_message ) hd;
		struct dlm_ls *ls;
		int error;
		int error = 0;

		if (!recovery)
		dlm_message_in(ms);
		@@ -3135,7 +3135,7 @@ int dlm_receive_message(struct dlm_header *hd, int nodeid, int recovery)
		out:
		dlm_put_lockspace(ls);
		dlm_astd_wake();
		return 0;
		return error;
		}

Admin message