Commit 8fc31ce8 authored Dec 04, 2016 by David Carrillo-Cisneros Committed by Ingo Molnar Dec 06, 2016

perf/core: Remove invalid warning from list_update_cgroup_even()t



The warning introduced in commit:

  864c2357 ("perf/core: Do not set cpuctx->cgrp for unscheduled cgroups")

assumed that a cgroup switch always precedes list_del_event. This is
not the case. Remove warning.

Make sure that cpuctx->cgrp is NULL until a cgroup event is sched in
or ctx->nr_cgroups == 0.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Nilay Vaish <nilayvaish@gmail.com>
Cc: Paul Turner <pjt@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi V Shankar <ravi.v.shankar@intel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/1480841177-27299-1-git-send-email-davidcc@google.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 7f612a7f

kernel/events/core.c

+8 −11

Original line number	Diff line number	Diff line
		@@ -903,17 +903,14 @@ list_update_cgroup_event(struct perf_event *event,
		*/
		cpuctx = __get_cpu_context(ctx);

		/* Only set/clear cpuctx->cgrp if current task uses event->cgrp. */
		if (perf_cgroup_from_task(current, ctx) != event->cgrp) {
		/*
		* We are removing the last cpu event in this context.
		* If that event is not active in this cpu, cpuctx->cgrp
		* should've been cleared by perf_cgroup_switch.
		* cpuctx->cgrp is NULL until a cgroup event is sched in or
		* ctx->nr_cgroup == 0 .
		*/
		WARN_ON_ONCE(!add && cpuctx->cgrp);
		return;
		}
		cpuctx->cgrp = add ? event->cgrp : NULL;
		if (add && perf_cgroup_from_task(current, ctx) == event->cgrp)
		cpuctx->cgrp = event->cgrp;
		else if (!add)
		cpuctx->cgrp = NULL;
		}

		#else /* !CONFIG_CGROUP_PERF */

Admin message