Commit 8fb7475b authored Oct 05, 2011 by Dan Carpenter Committed by John W. Linville Oct 11, 2011

ath5k: remove some unneeded error handling code



th5k_hw_setup_tx_queue() returns a valid offset into the ah->ah_txq[]
array.  The ah->ah_txq[] and the ah->txqs[] array are the same size.
Both have AR5K_NUM_TX_QUEUES elements.  So this error handling code
will never trigger.

Also it's wrong.  The call to ath5k_hw_release_tx_queue() with a qnum
of AR5K_NUM_TX_QUEUES or more will just trigger a WARN_ON() and
return.  Or if it missed the WARN_ON(), it would just corrupt some
memory and return.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 28a1bcdb

drivers/net/wireless/ath/ath5k/base.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -921,12 +921,6 @@ ath5k_txq_setup(struct ath5k_hw *ah,
		*/
		return ERR_PTR(qnum);
		}
		if (qnum >= ARRAY_SIZE(ah->txqs)) {
		ATH5K_ERR(ah, "hw qnum %u out of range, max %tu!\n",
		qnum, ARRAY_SIZE(ah->txqs));
		ath5k_hw_release_tx_queue(ah, qnum);
		return ERR_PTR(-EINVAL);
		}
		txq = &ah->txqs[qnum];
		if (!txq->setup) {
		txq->qnum = qnum;

Admin message