Commit 8fa8031c authored by Tomi Valkeinen's avatar Tomi Valkeinen
Browse files

OMAP: DSS2: Handle manager change in apply 



Currently when changing the manager of an overlay, set_manager() directly
calls dispc to set the overlay's destination.

Change this to be more in line with other overlay configurations, and
this will also remove the need to have dispc clocks enabled when calling
set_manager().

A new field is added to overlay struct, "manager_changed". This is
similar to "display_changed" field in manager struct, and is used to
inform apply that the manager has changed and thus write to the
registers is needed.

Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 5e785091

drivers/video/omap2/dss/dispc.c

+3 −1
Original line number Diff line number Diff line
@@ -841,7 +841,7 @@ static void _dispc_set_color_mode(enum omap_plane plane, 
	REG_FLD_MOD(DISPC_OVL_ATTRIBUTES(plane), m, 4, 1);

}



void dispc_set_channel_out(enum omap_plane plane,

static void dispc_set_channel_out(enum omap_plane plane,

		enum omap_channel channel)

{

	int shift;
@@ -1860,6 +1860,8 @@ int dispc_setup_plane(enum omap_plane plane, 
	_dispc_set_pre_mult_alpha(plane, pre_mult_alpha);

	_dispc_setup_global_alpha(plane, global_alpha);



	dispc_set_channel_out(plane, channel);



	return 0;

}

drivers/video/omap2/dss/dss.h

+0 −2
Original line number Diff line number Diff line
@@ -399,8 +399,6 @@ void dispc_set_plane_ba0(enum omap_plane plane, u32 paddr); 
void dispc_set_plane_ba1(enum omap_plane plane, u32 paddr);

void dispc_set_plane_pos(enum omap_plane plane, u16 x, u16 y);

void dispc_set_plane_size(enum omap_plane plane, u16 width, u16 height);

void dispc_set_channel_out(enum omap_plane plane,

		enum omap_channel channel_out);



void dispc_enable_gamma_table(bool enable);

int dispc_setup_plane(enum omap_plane plane,

drivers/video/omap2/dss/manager.c

+5 −0
Original line number Diff line number Diff line
@@ -1338,6 +1338,11 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr) 


		oc = &dss_cache.overlay_cache[ovl->id];



		if (ovl->manager_changed) {

			ovl->manager_changed = false;

			ovl->info_dirty  = true;

		}



		if (!overlay_enabled(ovl)) {

			if (oc->enabled) {

				oc->enabled = false;

drivers/video/omap2/dss/overlay.c

+2 −7
Original line number Diff line number Diff line
@@ -516,6 +516,7 @@ static int omap_dss_set_manager(struct omap_overlay *ovl, 
	}



	ovl->manager = mgr;

	ovl->manager_changed = true;



	/* XXX: When there is an overlay on a DSI manual update display, and

	 * the overlay is first disabled, then moved to tv, and enabled, we
@@ -529,15 +530,12 @@ static int omap_dss_set_manager(struct omap_overlay *ovl, 
	 * Userspace workaround for this is to update the LCD after disabling

	 * the overlay, but before moving the overlay to TV.

	 */

	dispc_set_channel_out(ovl->id, mgr->id);



	return 0;

}



static int omap_dss_unset_manager(struct omap_overlay *ovl)

{

	int r;



	if (!ovl->manager) {

		DSSERR("failed to detach overlay: manager not set\n");

		return -EINVAL;
@@ -548,11 +546,8 @@ static int omap_dss_unset_manager(struct omap_overlay *ovl) 
		return -EINVAL;

	}



	r = ovl->wait_for_go(ovl);

	if (r)

		return r;



	ovl->manager = NULL;

	ovl->manager_changed = true;



	return 0;

}

include/video/omapdss.h

+1 −0
Original line number Diff line number Diff line
@@ -333,6 +333,7 @@ struct omap_overlay { 
	struct omap_overlay_manager *manager;

	struct omap_overlay_info info;



	bool manager_changed;

	/* if true, info has been changed, but not applied() yet */

	bool info_dirty;

CRA Git | Maintained and supported by SUSTech CRA and CCSE