Commit 8f9ff189 authored Oct 30, 2013 by Lukas Czerner Committed by Theodore Ts'o Oct 30, 2013

ext4: fix FITRIM in no journal mode



When using FITRIM ioctl on a file system without journal it will
only trim the block group once, no matter how many times you invoke
FITRIM ioctl and how many block you release from the block group.

It is because we only clear EXT4_GROUP_INFO_WAS_TRIMMED_BIT in journal
callback. Fix this by clearing the bit in no journal mode as well.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reported-by: Jorge Fábregas <jorge.fabregas@gmail.com>

parent 5ba052fe

fs/ext4/mballoc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4794,8 +4794,8 @@ do_more:
		" group:%d block:%d count:%lu failed"
		" with %d", block_group, bit, count,
		err);
		}

		} else
		EXT4_MB_GRP_CLEAR_TRIMMED(e4b.bd_info);

		ext4_lock_group(sb, block_group);
		mb_clear_bits(bitmap_bh->b_data, bit, count_clusters);

Admin message