staging: wilc1000: change handle_get_ip_address's return type to void (8f9d9e00) · Commits · 戴 / test

When handle_get_ip_address is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by:

Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/wilc1000/host_interface.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -374,7 +374,7 @@ static void handle_set_ip_address(struct wilc_vif vif, u8 ip_addr, u8 idx)
		netdev_err(vif->ndev, "Failed to set IP address\n");
		}

		static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)
		static void handle_get_ip_address(struct wilc_vif *vif, u8 idx)
		{
		s32 result = 0;
		struct wid wid;
		@@ -394,12 +394,8 @@ static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)
		if (memcmp(get_ip[idx], set_ip[idx], IP_ALEN) != 0)
		wilc_setup_ipaddress(vif, set_ip[idx], idx);

		if (result != 0) {
		if (result != 0)
		netdev_err(vif->ndev, "Failed to get IP address\n");
		return -EINVAL;
		}

		return result;
		}

		static s32 handle_get_mac_address(struct wilc_vif *vif,

Admin message