PCI: Remove unused pcie_aspm_enabled() (8f92fb06) · Commits · 戴 / test

My philosophy is unused code is dead code. And dead code is subject to bit rot and is a likely source of bugs. Use it or lose it. This reverts part of ("ACPI/PCI: PCIe ASPM _OSC support capabilities called when root bridge added"), removing this interface: pcie_aspm_enabled() [bhelgaas: split to separate patch] Signed-off-by:

Stephen Hemminger <stephen@networkplumber.org> Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com> CC: Andrew Patterson <andrew.patterson@hp.com>

drivers/pci/pcie/aspm.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -984,18 +984,6 @@ void pcie_no_aspm(void)
		}
		}

		/**
		* pcie_aspm_enabled - is PCIe ASPM enabled?
		*
		* Returns true if ASPM has not been disabled by the command-line option
		* pcie_aspm=off.
		**/
		int pcie_aspm_enabled(void)
		{
		return !aspm_disabled;
		}
		EXPORT_SYMBOL(pcie_aspm_enabled);

		bool pcie_aspm_support_enabled(void)
		{
		return aspm_support_enabled;

include/linux/pci.h

+0 −2

Original line number	Diff line number	Diff line
		@@ -1200,10 +1200,8 @@ extern bool pcie_ports_auto;
		#endif

		#ifndef CONFIG_PCIEASPM
		static inline int pcie_aspm_enabled(void) { return 0; }
		static inline bool pcie_aspm_support_enabled(void) { return false; }
		#else
		int pcie_aspm_enabled(void);
		bool pcie_aspm_support_enabled(void);
		#endif

Admin message