Commit 8f86f837 authored Jan 13, 2015 by Steven Rostedt (Red Hat) Committed by Steven Rostedt Jan 15, 2015

ftrace: Fix updating of filters for shared global_ops filters

As the set_ftrace_filter affects both the function tracer as well as the
function graph tracer, the ops that represent each have a shared
ftrace_ops_hash structure. This allows both to be updated when the filter
files are updated.

But if function graph is enabled and the global_ops (function tracing) ops
is not, then it is possible that the filter could be changed without the
update happening for the function graph ops. This will cause the changes
to not take place and may even cause a ftrace_bug to occur as it could mess
with the trampoline accounting.

The solution is to check if the ops uses the shared global_ops filter and
if the ops itself is not enabled, to check if there's another ops that is
enabled and also shares the global_ops filter. In that case, the
modification still needs to be executed.

Link: http://lkml.kernel.org/r/20150114154329.055980438@goodmis.org



Cc: stable@vger.kernel.org # 3.17+
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent b1940cd2

kernel/trace/ftrace.c

+25 −1

Original line number	Diff line number	Diff line
		@@ -4008,8 +4008,32 @@ ftrace_match_addr(struct ftrace_hash *hash, unsigned long ip, int remove)
		static void ftrace_ops_update_code(struct ftrace_ops *ops,
		struct ftrace_hash *old_hash)
		{
		if (ops->flags & FTRACE_OPS_FL_ENABLED && ftrace_enabled)
		struct ftrace_ops *op;

		if (!ftrace_enabled)
		return;

		if (ops->flags & FTRACE_OPS_FL_ENABLED) {
		ftrace_run_modify_code(ops, FTRACE_UPDATE_CALLS, old_hash);
		return;
		}

		/*
		* If this is the shared global_ops filter, then we need to
		* check if there is another ops that shares it, is enabled.
		* If so, we still need to run the modify code.
		*/
		if (ops->func_hash != &global_ops.local_hash)
		return;

		do_for_each_ftrace_op(op, ftrace_ops_list) {
		if (op->func_hash == &global_ops.local_hash &&
		op->flags & FTRACE_OPS_FL_ENABLED) {
		ftrace_run_modify_code(op, FTRACE_UPDATE_CALLS, old_hash);
		/* Only need to do this once */
		return;
		}
		} while_for_each_ftrace_op(op);
		}

		static int

Admin message