dmaengine: ti: k3-udma: Remove redundant is_slave_direction() checks (8f757317) · Commits · 戴 / test

The direction has been already validated in the main callback and there is no need to check it again in the TR mode handlers for slave_sg and cyclic. Signed-off-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Link: https://lore.kernel.org/r/20200824120120.9270-1-peter.ujfalusi@ti.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/ti/k3-udma.c

+0 −10

Original line number	Diff line number	Diff line
		@@ -2024,11 +2024,6 @@ udma_prep_slave_sg_tr(struct udma_chan uc, struct scatterlist sgl,
		int num_tr = 0;
		int tr_idx = 0;

		if (!is_slave_direction(dir)) {
		dev_err(uc->ud->dev, "Only slave cyclic is supported\n");
		return NULL;
		}

		/* estimate the number of TRs we will need */
		for_each_sg(sgl, sgent, sglen, i) {
		if (sg_dma_len(sgent) < SZ_64K)
		@@ -2400,11 +2395,6 @@ udma_prep_dma_cyclic_tr(struct udma_chan *uc, dma_addr_t buf_addr,
		unsigned int i;
		int num_tr;

		if (!is_slave_direction(dir)) {
		dev_err(uc->ud->dev, "Only slave cyclic is supported\n");
		return NULL;
		}

		num_tr = udma_get_tr_counters(period_len, __ffs(buf_addr), &tr0_cnt0,
		&tr0_cnt1, &tr1_cnt0);
		if (num_tr < 0) {

Admin message