Commit 8f73110f authored by Romain Perier's avatar Romain Perier Committed by Mark Brown
Browse files

of: Rename "poweroff-source" property to "system-power-controller" 



It reverts commit a4b4e046 ("of: Add standard property for poweroff capability").
As discussed on the mailing list, it makes more sense to rename back to the
old established property name, without the vendor prefix. Problem being that
the word "source" usually tends to be used for inputs and that is out of control
of the OS. The poweroff capability is an output which simply turns the
system-power off. Also, this property might be used by drivers which power-off
the system and power back on subsequent RTC alarms. This seems to suggest to
remove "poweroff" from the property name and to choose "system-power-controller"
as the more generic name. This patchs adds the required renaming changes and
defines an helper function which checks if this property is set.

Signed-off-by: default avatarRomain Perier <romain.perier@gmail.com>
Acked-by: default avatarGrant Likely <grant.likely@linaro.org>
Acked-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7a5f5d7b

Documentation/devicetree/bindings/regulator/act8865-regulator.txt

+2 −2
Original line number Diff line number Diff line
@@ -6,8 +6,8 @@ Required properties: 
- reg: I2C slave address



Optional properties:

- poweroff-source: Telling whether or not this pmic is controlling

  the system power. See Documentation/devicetree/bindings/power/poweroff.txt .

- system-power-controller: Telling whether or not this pmic is controlling

  the system power. See Documentation/devicetree/bindings/power/power-controller.txt .



Any standard regulator properties can be used to configure the single regulator.

drivers/regulator/act8865-regulator.c

+1 −1
Original line number Diff line number Diff line
@@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client, 
		return ret;

	}



	if (of_system_has_poweroff_source(dev->of_node)) {

	if (of_device_is_system_power_controller(dev->of_node)) {

		if (!pm_power_off) {

			act8865_i2c_client = client;

			act8865->off_reg = off_reg;

include/linux/of.h

+3 −3
Original line number Diff line number Diff line
@@ -867,14 +867,14 @@ static inline int of_changeset_update_property(struct of_changeset *ocs, 
extern int of_resolve_phandles(struct device_node *tree);



/**

 * of_system_has_poweroff_source - Tells if poweroff-source is found for device_node

 * of_device_is_system_power_controller - Tells if system-power-controller is found for device_node

 * @np: Pointer to the given device_node

 *

 * return true if present false otherwise

 */

static inline bool of_system_has_poweroff_source(const struct device_node *np)

static inline bool of_device_is_system_power_controller(const struct device_node *np)

{

	return of_property_read_bool(np, "poweroff-source");

	return of_property_read_bool(np, "system-power-controller");

}



#endif /* _LINUX_OF_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE