clk: bcm: rpi: Remove pllb_arm_lookup global pointer (8f60112f) · Commits · 戴 / test

The pllb_arm_lookup pointer in the struct raspberrypi_clk is not used for anything but to store the returned pointer to clkdev_hw_create, and is not used anywhere else in the driver. Let's remove that global pointer from the structure. Cc: Michael Turquette <mturquette@baylibre.com> Cc: linux-clk@vger.kernel.org Acked-by:

Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Reviewed-by:

Stephen Boyd <sboyd@kernel.org> Tested-by:

Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Signed-off-by:

Maxime Ripard <maxime@cerno.tech> Link: https://lore.kernel.org/r/189407f54906d2b07c91de7a4eeb6d8c8934280f.1592210452.git-series.maxime@cerno.tech Signed-off-by:

Stephen Boyd <sboyd@kernel.org>

drivers/clk/bcm/clk-raspberrypi.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -40,7 +40,6 @@ struct raspberrypi_clk {
		unsigned long max_rate;

		struct clk_hw pllb;
		struct clk_lookup *pllb_arm_lookup;
		};

		/*
		@@ -238,6 +237,7 @@ static struct clk_fixed_factor raspberrypi_clk_pllb_arm = {

		static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
		{
		struct clk_lookup *pllb_arm_lookup;
		int ret;

		ret = devm_clk_hw_register(rpi->dev, &raspberrypi_clk_pllb_arm.hw);
		@@ -246,9 +246,9 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
		return ret;
		}

		rpi->pllb_arm_lookup = clkdev_hw_create(&raspberrypi_clk_pllb_arm.hw,
		pllb_arm_lookup = clkdev_hw_create(&raspberrypi_clk_pllb_arm.hw,
		NULL, "cpu0");
		if (!rpi->pllb_arm_lookup) {
		if (!pllb_arm_lookup) {
		dev_err(rpi->dev, "Failed to initialize pllb_arm_lookup\n");
		return -ENOMEM;
		}

Admin message