dmaengine: sun6i: use of_device_get_match_data (8f3b0034) · Commits · 戴 / test

The usage of of_device_get_match_data reduce the code size a bit. Furthermore, it prevents an improbable dereference when of_match_device() return NULL. Acked-by:

Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by:

Corentin Labbe <clabbe.montjoie@gmail.com> Signed-off-by:

Vinod Koul <vinod.koul@intel.com>

drivers/dma/sun6i-dma.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1064,7 +1064,6 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match);

		static int sun6i_dma_probe(struct platform_device *pdev)
		{
		const struct of_device_id *device;
		struct sun6i_dma_dev *sdc;
		struct resource *res;
		int ret, i;
		@@ -1073,10 +1072,9 @@ static int sun6i_dma_probe(struct platform_device *pdev)
		if (!sdc)
		return -ENOMEM;

		device = of_match_device(sun6i_dma_match, &pdev->dev);
		if (!device)
		sdc->cfg = of_device_get_match_data(&pdev->dev);
		if (!sdc->cfg)
		return -ENODEV;
		sdc->cfg = device->data;

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		sdc->base = devm_ioremap_resource(&pdev->dev, res);

Admin message