Commit 8f294324 authored Jun 13, 2020 by Aditya Pakki Committed by Ben Skeggs Jul 24, 2020

drm/nouveau: fix reference count leak in nouveau_debugfs_strap_peek



nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that
increments the reference count. In case of failure, decrement the
ref count before returning the error.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 990a1162

drivers/gpu/drm/nouveau/nouveau_debugfs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -54,8 +54,10 @@ nouveau_debugfs_strap_peek(struct seq_file m, void data)
		int ret;

		ret = pm_runtime_get_sync(drm->dev->dev);
		if (ret < 0 && ret != -EACCES)
		if (ret < 0 && ret != -EACCES) {
		pm_runtime_put_autosuspend(drm->dev->dev);
		return ret;
		}

		seq_printf(m, "0x%08x\n",
		nvif_rd32(&drm->client.device.object, 0x101000));

Admin message