Commit 8f2828d7 authored Dec 26, 2019 by Christophe JAILLET Committed by Jiri Kosina Jan 13, 2020

HID: logitech-hidpp: avoid duplicate error handling code in 'hidpp_probe()'



'hid_hw_stop()' is already in the error handling path when branching to
the 'hid_hw_open_fail' label.
There is no point in calling it twice, so remove one.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent be281368

drivers/hid/hid-logitech-hidpp.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3817,7 +3817,6 @@ static int hidpp_probe(struct hid_device hdev, const struct hid_device_id id)
		if (ret < 0) {
		dev_err(&hdev->dev, "%s:hid_hw_open returned error:%d\n",
		__func__, ret);
		hid_hw_stop(hdev);
		goto hid_hw_open_fail;
		}

Admin message