Commit 8f189738 authored Oct 09, 2018 by Qiuxu Zhuo Committed by Borislav Petkov Oct 09, 2018

EDAC, skx_edac: Fix logical channel intermediate decoding



The code "lchan = (lchan << 1) | ~lchan" for logical channel
intermediate decoding is wrong. The wrong intermediate decoding
result is {0xffffffff, 0xfffffffe}.

Fix it by replacing '~' with '!'. The correct intermediate
decoding result is {0x1, 0x2}.

Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
CC: Aristeu Rozanski <aris@redhat.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-edac <linux-edac@vger.kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20181009172025.18594-1-tony.luck@intel.com

parent 432de7fd

drivers/edac/skx_edac.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -668,7 +668,7 @@ sad_found:
		break;
		case 2:
		lchan = (addr >> shift) % 2;
		lchan = (lchan << 1) \| ~lchan;
		lchan = (lchan << 1) \| !lchan;
		break;
		case 3:
		lchan = ((addr >> shift) % 2) << 1;

Admin message