Commit 8ef659f1 authored Apr 11, 2019 by Karsten Graul Committed by David S. Miller Apr 11, 2019

net/smc: fix return code from FLUSH command

The FLUSH command is used to empty the pnet table. No return code is
expected from the command. Commit a9d8b0b1e3d6 added namespace support
for the pnet table and changed the FLUSH command processing to call
smc_pnet_remove_by_pnetid() to remove the pnet entries. This function
returns -ENOENT when no entry was deleted, which is now the return code
of the FLUSH command. As a result the FLUSH command will return an error
when the pnet table is already empty.
Restore the expected behavior and let FLUSH always return 0.

Fixes: a9d8b0b1e3d6 ("net/smc: add pnet table namespace support")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 07603b23

net/smc/smc_pnet.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -603,7 +603,8 @@ static int smc_pnet_flush(struct sk_buff skb, struct genl_info info)
		{
		struct net *net = genl_info_net(info);

		return smc_pnet_remove_by_pnetid(net, NULL);
		smc_pnet_remove_by_pnetid(net, NULL);
		return 0;
		}

		/* SMC_PNETID generic netlink operation definition */

Admin message