Commit 8ef5849f authored Jan 14, 2016 by Joonsoo Kim Committed by Linus Torvalds Jan 14, 2016

mm/cma: always check which page caused allocation failure



Now, we have tracepoint in test_pages_isolated() to notify pfn which
cannot be isolated.  But, in alloc_contig_range(), some error path
doesn't call test_pages_isolated() so it's still hard to know exact pfn
that causes allocation failure.

This patch change this situation by calling test_pages_isolated() in
almost error path.  In allocation failure case, some overhead is added
by this change, but, allocation failure is really rare event so it would
not matter.

In fatal signal pending case, we don't call test_pages_isolated()
because this failure is intentional one.

There was a bogus outer_start problem due to unchecked buddy order and
this patch also fix it.  Before this patch, it didn't matter, because
end result is same thing.  But, after this patch, tracepoint will report
failed pfn so it should be accurate.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0f0848e5

mm/page_alloc.c

+20 −3

Original line number	Diff line number	Diff line
		@@ -6725,8 +6725,12 @@ int alloc_contig_range(unsigned long start, unsigned long end,
		if (ret)
		return ret;

		/*
		* In case of -EBUSY, we'd like to know which page causes problem.
		* So, just fall through. We will check it in test_pages_isolated().
		*/
		ret = __alloc_contig_migrate_range(&cc, start, end);
		if (ret)
		if (ret && ret != -EBUSY)
		goto done;

		/*
		@@ -6753,12 +6757,25 @@ int alloc_contig_range(unsigned long start, unsigned long end,
		outer_start = start;
		while (!PageBuddy(pfn_to_page(outer_start))) {
		if (++order >= MAX_ORDER) {
		ret = -EBUSY;
		goto done;
		outer_start = start;
		break;
		}
		outer_start &= ~0UL << order;
		}

		if (outer_start != start) {
		order = page_order(pfn_to_page(outer_start));

		/*
		* outer_start page could be small order buddy page and
		* it doesn't include start page. Adjust outer_start
		* in this case to report failed page properly
		* on tracepoint in test_pages_isolated()
		*/
		if (outer_start + (1UL << order) <= start)
		outer_start = start;
		}

		/* Make sure the range is really isolated. */
		if (test_pages_isolated(outer_start, end, false)) {
		pr_info("%s: [%lx, %lx) PFNs busy\n",

Admin message