Commit 8ed1e46a authored by Jeff Layton's avatar Jeff Layton
Browse files

mm: set both AS_EIO/AS_ENOSPC and errseq_t in mapping_set_error 



When a writeback error occurs, we want later callers to be able to pick
up that fact when they go to wait on that writeback to complete.
Traditionally, we've used AS_EIO/AS_ENOSPC flags to track that, but
that's problematic since only one "checker" will be informed when an
error occurs.

In later patches, we're going to want to convert many of these callers
to check for errors since a well-defined point in time. For now, ensure
that we can handle both sorts of checks by both setting errors in both
places when there is a writeback failure.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
parent 5660e13d

include/linux/pagemap.h

+25 −6
Original line number Diff line number Diff line
@@ -28,15 +28,34 @@ enum mapping_flags { 
	AS_NO_WRITEBACK_TAGS = 5,

};



/**

 * mapping_set_error - record a writeback error in the address_space

 * @mapping - the mapping in which an error should be set

 * @error - the error to set in the mapping

 *

 * When writeback fails in some way, we must record that error so that

 * userspace can be informed when fsync and the like are called.  We endeavor

 * to report errors on any file that was open at the time of the error.  Some

 * internal callers also need to know when writeback errors have occurred.

 *

 * When a writeback error occurs, most filesystems will want to call

 * mapping_set_error to record the error in the mapping so that it can be

 * reported when the application calls fsync(2).

 */

static inline void mapping_set_error(struct address_space *mapping, int error)

{

	if (unlikely(error)) {

	if (likely(!error))

		return;



	/* Record in wb_err for checkers using errseq_t based tracking */

	filemap_set_wb_err(mapping, error);



	/* Record it in flags for now, for legacy callers */

	if (error == -ENOSPC)

		set_bit(AS_ENOSPC, &mapping->flags);

	else

		set_bit(AS_EIO, &mapping->flags);

}

}



static inline void mapping_set_unevictable(struct address_space *mapping)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE