Commit 8ec69574 authored Dec 28, 2017 by Jiri Pirko Committed by David S. Miller Dec 28, 2017

net: sched: don't set extack message in case the qdisc will be created



If the qdisc is not found here, it is going to be created. Therefore,
this is not an error path. Remove the extack message set and don't
confuse user with error message in case the qdisc was created
successfully.

Fixes: 09215598 ("net: sched: sch_api: handle generic qdisc errors")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d3dbd7a6

net/sched/sch_api.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1402,10 +1402,8 @@ replay:
		return -EINVAL;
		}
		q = qdisc_lookup(dev, tcm->tcm_handle);
		if (!q) {
		NL_SET_ERR_MSG(extack, "No qdisc found for specified handle");
		if (!q)
		goto create_n_graft;
		}
		if (n->nlmsg_flags & NLM_F_EXCL) {
		NL_SET_ERR_MSG(extack, "Exclusivity flag on, cannot override");
		return -EEXIST;

Admin message