Commit 8eb73c6c authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: mei: fix debug code 



! has higher precedence than !=.  H_RDY is 8 and since neither 0 nor
1 are equal to 8 the original condition was always true.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e2d4dc5a

drivers/staging/mei/init.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -205,10 +205,10 @@ int mei_hw_init(struct mei_device *dev) 
			"host_hw_state = 0x%08x, me_hw_state = 0x%08x.\n",

			"host_hw_state = 0x%08x, me_hw_state = 0x%08x.\n",

			dev->host_hw_state, dev->me_hw_state);

			dev->host_hw_state, dev->me_hw_state);





		if (!(dev->host_hw_state & H_RDY) != H_RDY)

		if (!(dev->host_hw_state & H_RDY))

			dev_dbg(&dev->pdev->dev, "host turn off H_RDY.\n");

			dev_dbg(&dev->pdev->dev, "host turn off H_RDY.\n");





		if (!(dev->me_hw_state & ME_RDY_HRA) != ME_RDY_HRA)

		if (!(dev->me_hw_state & ME_RDY_HRA))

			dev_dbg(&dev->pdev->dev, "ME turn off ME_RDY.\n");

			dev_dbg(&dev->pdev->dev, "ME turn off ME_RDY.\n");





		printk(KERN_ERR "mei: link layer initialization failed.\n");

		printk(KERN_ERR "mei: link layer initialization failed.\n");

CRA Git | Maintained and supported by SUSTech CRA and CCSE