Unverified Commit 8eb2fd00 authored Aug 18, 2019 by Axel Lin Committed by Mark Brown Aug 20, 2019

spi: zynq-qspi: Fix missing spi_unregister_controller when unload module



Use devm_spi_register_controller to fix missing spi_unregister_controller
when unload module.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20190818095113.2397-1-axel.lin@ingics.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 52718908

drivers/spi/spi-zynq-qspi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -695,7 +695,7 @@ static int zynq_qspi_probe(struct platform_device *pdev)
		ctlr->setup = zynq_qspi_setup_op;
		ctlr->max_speed_hz = clk_get_rate(xqspi->refclk) / 2;
		ctlr->dev.of_node = np;
		ret = spi_register_controller(ctlr);
		ret = devm_spi_register_controller(&pdev->dev, ctlr);
		if (ret) {
		dev_err(&pdev->dev, "spi_register_master failed\n");
		goto clk_dis_all;

Admin message