Commit 8eb2dfac authored Feb 17, 2009 by Herbert Xu

crypto: lrw - Fix big endian support



It turns out that LRW has never worked properly on big endian.
This was never discussed because nobody actually used it that
way.  In fact, it was only discovered when Geert Uytterhoeven
loaded it through tcrypt which failed the test on it.

The fix is straightforward, on big endian the to find the nth
bit we should be grouping them by words instead of bytes.  So
setbit128_bbe should xor with 128 - BITS_PER_LONG instead of
128 - BITS_PER_BYTE == 0x78.

Tested-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent d2f8d7ee

crypto/lrw.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -45,7 +45,13 @@ struct priv {

		static inline void setbit128_bbe(void *b, int bit)
		{
		__set_bit(bit ^ 0x78, b);
		__set_bit(bit ^ (0x80 -
		#ifdef __BIG_ENDIAN
		BITS_PER_LONG
		#else
		BITS_PER_BYTE
		#endif
		), b);
		}

		static int setkey(struct crypto_tfm parent, const u8 key,

Admin message