Commit 8eab77ff authored by Filipe Manana's avatar Filipe Manana Committed by Chris Mason
Browse files

Btrfs: use global reserve when deleting unused block group after ENOSPC 



It's possible to reach a state where the cleaner kthread isn't able to
start a transaction to delete an unused block group due to lack of enough
free metadata space and due to lack of unallocated device space to allocate
a new metadata block group as well. If this happens try to use space from
the global block group reserve just like we do for unlink operations, so
that we don't reach a permanent state where starting a transaction for
filesystem operations (file creation, renames, etc) keeps failing with
-ENOSPC. Such an unfortunate state was observed on a machine where over
a dozen unused data block groups existed and the cleaner kthread was
failing to delete them due to ENOSPC error when attempting to start a
transaction, and even running balance with a -dusage=0 filter failed with
ENOSPC as well. Also unmounting and mounting again the filesystem didn't
help. Allowing the cleaner kthread to use the global block reserve to
delete the unused data block groups fixed the problem.

Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarJeff Mahoney <jeffm@suse.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent 89b6c8d1

fs/btrfs/ctree.h

+2 −0
Original line number Diff line number Diff line
@@ -3479,6 +3479,8 @@ int btrfs_make_block_group(struct btrfs_trans_handle *trans, 
			   struct btrfs_root *root, u64 bytes_used,

			   u64 type, u64 chunk_objectid, u64 chunk_offset,

			   u64 size);

struct btrfs_trans_handle *btrfs_start_trans_remove_block_group(

				struct btrfs_fs_info *fs_info);

int btrfs_remove_block_group(struct btrfs_trans_handle *trans,

			     struct btrfs_root *root, u64 group_start,

			     struct extent_map *em);

fs/btrfs/extent-tree.c

+12 −2
Original line number Diff line number Diff line
@@ -10256,6 +10256,17 @@ out: 
	return ret;

}



struct btrfs_trans_handle *

btrfs_start_trans_remove_block_group(struct btrfs_fs_info *fs_info)

{

	/*

	 * 1 unit for adding the free space inode's orphan (located in the tree

	 * of tree roots).

	 */

	return btrfs_start_transaction_fallback_global_rsv(fs_info->extent_root,

							   1, 1);

}



/*

 * Process the unused_bgs list and remove any that don't have any allocated

 * space inside of them.
@@ -10322,8 +10333,7 @@ void btrfs_delete_unused_bgs(struct btrfs_fs_info *fs_info) 
		 * Want to do this before we do anything else so we can recover

		 * properly if we fail to join the transaction.

		 */

		/* 1 for btrfs_orphan_reserve_metadata() */

		trans = btrfs_start_transaction(root, 1);

		trans = btrfs_start_trans_remove_block_group(fs_info);

		if (IS_ERR(trans)) {

			btrfs_dec_block_group_ro(root, block_group);

			ret = PTR_ERR(trans);

fs/btrfs/inode.c

+1 −23
Original line number Diff line number Diff line
@@ -4046,9 +4046,7 @@ int btrfs_unlink_inode(struct btrfs_trans_handle *trans, 
 */

static struct btrfs_trans_handle *__unlink_start_trans(struct inode *dir)

{

	struct btrfs_trans_handle *trans;

	struct btrfs_root *root = BTRFS_I(dir)->root;

	int ret;



	/*

	 * 1 for the possible orphan item
@@ -4057,27 +4055,7 @@ static struct btrfs_trans_handle *__unlink_start_trans(struct inode *dir) 
	 * 1 for the inode ref

	 * 1 for the inode

	 */

	trans = btrfs_start_transaction(root, 5);

	if (!IS_ERR(trans) || PTR_ERR(trans) != -ENOSPC)

		return trans;



	if (PTR_ERR(trans) == -ENOSPC) {

		u64 num_bytes = btrfs_calc_trans_metadata_size(root, 5);



		trans = btrfs_start_transaction(root, 0);

		if (IS_ERR(trans))

			return trans;

		ret = btrfs_cond_migrate_bytes(root->fs_info,

					       &root->fs_info->trans_block_rsv,

					       num_bytes, 5);

		if (ret) {

			btrfs_end_transaction(trans, root);

			return ERR_PTR(ret);

		}

		trans->block_rsv = &root->fs_info->trans_block_rsv;

		trans->bytes_reserved = num_bytes;

	}

	return trans;

	return btrfs_start_transaction_fallback_global_rsv(root, 5, 5);

}



static int btrfs_unlink(struct inode *dir, struct dentry *dentry)

fs/btrfs/transaction.c

+32 −0
Original line number Diff line number Diff line
@@ -592,6 +592,38 @@ struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root, 
	return start_transaction(root, num_items, TRANS_START,

				 BTRFS_RESERVE_FLUSH_ALL);

}

struct btrfs_trans_handle *btrfs_start_transaction_fallback_global_rsv(

					struct btrfs_root *root,

					unsigned int num_items,

					int min_factor)

{

	struct btrfs_trans_handle *trans;

	u64 num_bytes;

	int ret;



	trans = btrfs_start_transaction(root, num_items);

	if (!IS_ERR(trans) || PTR_ERR(trans) != -ENOSPC)

		return trans;



	trans = btrfs_start_transaction(root, 0);

	if (IS_ERR(trans))

		return trans;



	num_bytes = btrfs_calc_trans_metadata_size(root, num_items);

	ret = btrfs_cond_migrate_bytes(root->fs_info,

				       &root->fs_info->trans_block_rsv,

				       num_bytes,

				       min_factor);

	if (ret) {

		btrfs_end_transaction(trans, root);

		return ERR_PTR(ret);

	}



	trans->block_rsv = &root->fs_info->trans_block_rsv;

	trans->bytes_reserved = num_bytes;



	return trans;

}



struct btrfs_trans_handle *btrfs_start_transaction_lflush(

					struct btrfs_root *root,

fs/btrfs/transaction.h

+4 −0
Original line number Diff line number Diff line
@@ -185,6 +185,10 @@ int btrfs_end_transaction(struct btrfs_trans_handle *trans, 
			  struct btrfs_root *root);

struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,

						   unsigned int num_items);

struct btrfs_trans_handle *btrfs_start_transaction_fallback_global_rsv(

					struct btrfs_root *root,

					unsigned int num_items,

					int min_factor);

struct btrfs_trans_handle *btrfs_start_transaction_lflush(

					struct btrfs_root *root,

					unsigned int num_items);

CRA Git | Maintained and supported by SUSTech CRA and CCSE