drm/msm: Stop dropping struct_mutex in recover_worker() (8ea274ac) · Commits · 戴 / test

Now that we don't have the mmap_sem lock inversion, we don't need to jump through this particular hoop anymore. Signed-off-by:

drivers/gpu/drm/msm/msm_gpu.c

+0 −13

Original line number	Diff line number	Diff line
		@@ -450,21 +450,8 @@ static void recover_worker(struct work_struct *work)
		task = get_pid_task(submit->pid, PIDTYPE_PID);
		if (task) {
		comm = kstrdup(task->comm, GFP_KERNEL);

		/*
		* So slightly annoying, in other paths like
		* mmap'ing gem buffers, mmap_sem is acquired
		* before struct_mutex, which means we can't
		* hold struct_mutex across the call to
		* get_cmdline(). But submits are retired
		* from the same in-order workqueue, so we can
		* safely drop the lock here without worrying
		* about the submit going away.
		*/
		mutex_unlock(&dev->struct_mutex);
		cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL);
		put_task_struct(task);
		mutex_lock(&dev->struct_mutex);
		}

		if (comm && cmd) {