Commit 8e9faa15 authored Jan 30, 2017 by Johan Hovold Committed by Jiri Kosina Jan 31, 2017

HID: cp2112: fix gpio-callback error handling



In case of a zero-length report, the gpio direction_input callback would
currently return success instead of an errno.

Fixes: 1ffb3c40 ("HID: cp2112: make transfer buffers DMA capable")
Cc: stable <stable@vger.kernel.org>     # 4.9
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 7a7b5df8

drivers/hid/hid-cp2112.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -213,7 +213,7 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset)

	exit:		exit:
	mutex_unlock(&dev->lock);		mutex_unlock(&dev->lock);
	return ret <= 0 ? ret : -EIO;		return ret < 0 ? ret : -EIO;
	}		}

	static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)		static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)

Admin message