Commit 8e9394ce authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

Driver core: create lock/unlock functions for struct device 



In the future, we are going to be changing the lock type for struct
device (once we get the lockdep infrastructure properly worked out)  To
make that changeover easier, and to possibly burry the lock in a
different part of struct device, let's create some functions to lock and
unlock a device so that no out-of-core code needs to be changed in the
future.

This patch creates the device_lock/unlock/trylock() functions, and
converts all in-tree users to them.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Dave Young <hidave.darkstar@gmail.com>
Cc: Ming Lei <tom.leiming@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <len.brown@intel.com>
Cc: Magnus Damm <damm@igel.co.jp>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Alex Chiang <achiang@hp.com>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrew Patterson <andrew.patterson@hp.com>
Cc: Yu Zhao <yu.zhao@intel.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: CHENG Renquan <rqcheng@smu.edu.sg>
Cc: Oliver Neukum <oliver@neukum.org>
Cc: Frans Pop <elendil@planet.nl>
Cc: David Vrabel <david.vrabel@csr.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 62e877b8

drivers/base/bus.c

+10 −10
Original line number Diff line number Diff line
@@ -173,10 +173,10 @@ static ssize_t driver_unbind(struct device_driver *drv, 
	dev = bus_find_device_by_name(bus, NULL, buf);

	if (dev && dev->driver == drv) {

		if (dev->parent)	/* Needed for USB */

			down(&dev->parent->sem);

			device_lock(dev->parent);

		device_release_driver(dev);

		if (dev->parent)

			up(&dev->parent->sem);

			device_unlock(dev->parent);

		err = count;

	}

	put_device(dev);
@@ -200,12 +200,12 @@ static ssize_t driver_bind(struct device_driver *drv, 
	dev = bus_find_device_by_name(bus, NULL, buf);

	if (dev && dev->driver == NULL && driver_match_device(drv, dev)) {

		if (dev->parent)	/* Needed for USB */

			down(&dev->parent->sem);

		down(&dev->sem);

			device_lock(dev->parent);

		device_lock(dev);

		err = driver_probe_device(drv, dev);

		up(&dev->sem);

		device_unlock(dev);

		if (dev->parent)

			up(&dev->parent->sem);

			device_unlock(dev->parent);



		if (err > 0) {

			/* success */
@@ -744,10 +744,10 @@ static int __must_check bus_rescan_devices_helper(struct device *dev, 


	if (!dev->driver) {

		if (dev->parent)	/* Needed for USB */

			down(&dev->parent->sem);

			device_lock(dev->parent);

		ret = device_attach(dev);

		if (dev->parent)

			up(&dev->parent->sem);

			device_unlock(dev->parent);

	}

	return ret < 0 ? ret : 0;

}
@@ -779,10 +779,10 @@ int device_reprobe(struct device *dev) 
{

	if (dev->driver) {

		if (dev->parent)        /* Needed for USB */

			down(&dev->parent->sem);

			device_lock(dev->parent);

		device_release_driver(dev);

		if (dev->parent)

			up(&dev->parent->sem);

			device_unlock(dev->parent);

	}

	return bus_rescan_devices_helper(dev, NULL);

}

drivers/base/dd.c

+19 −19
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static void driver_sysfs_remove(struct device *dev) 
 * for before calling this. (It is ok to call with no other effort

 * from a driver's probe() method.)

 *

 * This function must be called with @dev->sem held.

 * This function must be called with the device lock held.

 */

int device_bind_driver(struct device *dev)

{
@@ -190,8 +190,8 @@ EXPORT_SYMBOL_GPL(wait_for_device_probe); 
 * This function returns -ENODEV if the device is not registered,

 * 1 if the device is bound successfully and 0 otherwise.

 *

 * This function must be called with @dev->sem held.  When called for a

 * USB interface, @dev->parent->sem must be held as well.

 * This function must be called with @dev lock held.  When called for a

 * USB interface, @dev->parent lock must be held as well.

 */

int driver_probe_device(struct device_driver *drv, struct device *dev)

{
@@ -233,13 +233,13 @@ static int __device_attach(struct device_driver *drv, void *data) 
 * 0 if no matching driver was found;

 * -ENODEV if the device is not registered.

 *

 * When called for a USB interface, @dev->parent->sem must be held.

 * When called for a USB interface, @dev->parent lock must be held.

 */

int device_attach(struct device *dev)

{

	int ret = 0;



	down(&dev->sem);

	device_lock(dev);

	if (dev->driver) {

		ret = device_bind_driver(dev);

		if (ret == 0)
@@ -253,7 +253,7 @@ int device_attach(struct device *dev) 
		ret = bus_for_each_drv(dev->bus, NULL, dev, __device_attach);

		pm_runtime_put_sync(dev);

	}

	up(&dev->sem);

	device_unlock(dev);

	return ret;

}

EXPORT_SYMBOL_GPL(device_attach);
@@ -276,13 +276,13 @@ static int __driver_attach(struct device *dev, void *data) 
		return 0;



	if (dev->parent)	/* Needed for USB */

		down(&dev->parent->sem);

	down(&dev->sem);

		device_lock(dev->parent);

	device_lock(dev);

	if (!dev->driver)

		driver_probe_device(drv, dev);

	up(&dev->sem);

	device_unlock(dev);

	if (dev->parent)

		up(&dev->parent->sem);

		device_unlock(dev->parent);



	return 0;

}
@@ -303,8 +303,8 @@ int driver_attach(struct device_driver *drv) 
EXPORT_SYMBOL_GPL(driver_attach);



/*

 * __device_release_driver() must be called with @dev->sem held.

 * When called for a USB interface, @dev->parent->sem must be held as well.

 * __device_release_driver() must be called with @dev lock held.

 * When called for a USB interface, @dev->parent lock must be held as well.

 */

static void __device_release_driver(struct device *dev)

{
@@ -343,7 +343,7 @@ static void __device_release_driver(struct device *dev) 
 * @dev: device.

 *

 * Manually detach device from driver.

 * When called for a USB interface, @dev->parent->sem must be held.

 * When called for a USB interface, @dev->parent lock must be held.

 */

void device_release_driver(struct device *dev)

{
@@ -352,9 +352,9 @@ void device_release_driver(struct device *dev) 
	 * within their ->remove callback for the same device, they

	 * will deadlock right here.

	 */

	down(&dev->sem);

	device_lock(dev);

	__device_release_driver(dev);

	up(&dev->sem);

	device_unlock(dev);

}

EXPORT_SYMBOL_GPL(device_release_driver);
@@ -381,13 +381,13 @@ void driver_detach(struct device_driver *drv) 
		spin_unlock(&drv->p->klist_devices.k_lock);



		if (dev->parent)	/* Needed for USB */

			down(&dev->parent->sem);

		down(&dev->sem);

			device_lock(dev->parent);

		device_lock(dev);

		if (dev->driver == drv)

			__device_release_driver(dev);

		up(&dev->sem);

		device_unlock(dev);

		if (dev->parent)

			up(&dev->parent->sem);

			device_unlock(dev->parent);

		put_device(dev);

	}

}

drivers/base/power/main.c

+10 −10
Original line number Diff line number Diff line
@@ -35,8 +35,8 @@ 
 * because children are guaranteed to be discovered after parents, and

 * are inserted at the back of the list on discovery.

 *

 * Since device_pm_add() may be called with a device semaphore held,

 * we must never try to acquire a device semaphore while holding

 * Since device_pm_add() may be called with a device lock held,

 * we must never try to acquire a device lock while holding

 * dpm_list_mutex.

 */
@@ -508,7 +508,7 @@ static int device_resume(struct device *dev, pm_message_t state, bool async) 
	TRACE_RESUME(0);



	dpm_wait(dev->parent, async);

	down(&dev->sem);

	device_lock(dev);



	dev->power.status = DPM_RESUMING;
@@ -543,7 +543,7 @@ static int device_resume(struct device *dev, pm_message_t state, bool async) 
		}

	}

 End:

	up(&dev->sem);

	device_unlock(dev);

	complete_all(&dev->power.completion);



	TRACE_RESUME(error);
@@ -629,7 +629,7 @@ static void dpm_resume(pm_message_t state) 
 */

static void device_complete(struct device *dev, pm_message_t state)

{

	down(&dev->sem);

	device_lock(dev);



	if (dev->class && dev->class->pm && dev->class->pm->complete) {

		pm_dev_dbg(dev, state, "completing class ");
@@ -646,7 +646,7 @@ static void device_complete(struct device *dev, pm_message_t state) 
		dev->bus->pm->complete(dev);

	}



	up(&dev->sem);

	device_unlock(dev);

}



/**
@@ -809,7 +809,7 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) 
	int error = 0;



	dpm_wait_for_children(dev, async);

	down(&dev->sem);

	device_lock(dev);



	if (async_error)

		goto End;
@@ -849,7 +849,7 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) 
		dev->power.status = DPM_OFF;



 End:

	up(&dev->sem);

	device_unlock(dev);

	complete_all(&dev->power.completion);



	return error;
@@ -938,7 +938,7 @@ static int device_prepare(struct device *dev, pm_message_t state) 
{

	int error = 0;



	down(&dev->sem);

	device_lock(dev);



	if (dev->bus && dev->bus->pm && dev->bus->pm->prepare) {

		pm_dev_dbg(dev, state, "preparing ");
@@ -962,7 +962,7 @@ static int device_prepare(struct device *dev, pm_message_t state) 
		suspend_report_result(dev->class->pm->prepare, error);

	}

 End:

	up(&dev->sem);

	device_unlock(dev);



	return error;

}

drivers/firewire/core-device.c

+2 −3
Original line number Diff line number Diff line
@@ -33,7 +33,6 @@ 
#include <linux/module.h>

#include <linux/mutex.h>

#include <linux/rwsem.h>

#include <linux/semaphore.h>

#include <linux/spinlock.h>

#include <linux/string.h>

#include <linux/workqueue.h>
@@ -828,9 +827,9 @@ static int update_unit(struct device *dev, void *data) 
	struct fw_driver *driver = (struct fw_driver *)dev->driver;



	if (is_fw_unit(dev) && driver != NULL && driver->update != NULL) {

		down(&dev->sem);

		device_lock(dev);

		driver->update(unit);

		up(&dev->sem);

		device_unlock(dev);

	}



	return 0;

drivers/ieee1394/nodemgr.c

+2 −3
Original line number Diff line number Diff line
@@ -19,7 +19,6 @@ 
#include <linux/moduleparam.h>

#include <linux/mutex.h>

#include <linux/freezer.h>

#include <linux/semaphore.h>

#include <asm/atomic.h>



#include "csr.h"
@@ -1397,9 +1396,9 @@ static int update_pdrv(struct device *dev, void *data) 
			pdrv = container_of(drv, struct hpsb_protocol_driver,

					    driver);

			if (pdrv->update) {

				down(&ud->device.sem);

				device_lock(&ud->device);

				error = pdrv->update(ud);

				up(&ud->device.sem);

				device_unlock(&ud->device);

			}

			if (error)

				device_release_driver(&ud->device);

CRA Git | Maintained and supported by SUSTech CRA and CCSE