Commit 8e84172e authored Feb 09, 2020 by Dmitry Osipenko Committed by Vinod Koul Feb 25, 2020

dmaengine: tegra-apb: Prevent race conditions on channel's freeing



It's incorrect to check the channel's "busy" state without taking a lock.
That shouldn't cause any real troubles, nevertheless it's always better
not to have any race conditions in the code.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20200209163356.6439-5-digetx@gmail.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent dda5e35a

drivers/dma/tegra20-apb-dma.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1298,7 +1298,6 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc)

		dev_dbg(tdc2dev(tdc), "Freeing channel %d\n", tdc->id);

		if (tdc->busy)
		tegra_dma_terminate_all(dc);

		spin_lock_irqsave(&tdc->lock, flags);

Admin message