coccicheck: make SPFLAGS more useful (8e826ad5) · Commits · 戴 / test

SPFLAGS is set early, it means that any heuristics done on coccicheck cannot be overridden currently. Move SPFLAGS after OPTIONS and set this at the end. This lets you override any heuristics as coccinelle treats conflicts by only listening to the last option that makes sense. v3: this patch was added in the v3 series v4: Update Documentation/coccinelle.txt explaining how SPFLAGS works as well. Signed-off-by:

Luis R. Rodriguez <mcgrof@kernel.org> Acked-by:

Nicolas Palix <nicolas.palix@imag.fr> Signed-off-by:

Michal Marek <mmarek@suse.com>

Documentation/coccinelle.txt

+2 −1

Original line number	Diff line number	Diff line
		@@ -146,7 +146,8 @@ MODE variable explained above.
		~~~~~~~~~~~~~~~~~~

		Additional flags can be passed to spatch through the SPFLAGS
		variable.
		variable. This works as Coccinelle respects the last flags
		given to it when options are in conflict.

		make SPFLAGS=--use-glimpse coccicheck
		make SPFLAGS=--use-idutils coccicheck

scripts/coccicheck

+4 −1

Original line number	Diff line number	Diff line
		@@ -30,7 +30,7 @@ else
		NPROC="$J"
		fi

		FLAGS="--very-quiet $SPFLAGS"
		FLAGS="--very-quiet"

		# spatch only allows include directories with the syntax "-I include"
		# while gcc also allows "-Iinclude" and "-include include"
		@@ -106,6 +106,9 @@ kill_running() {
		done
		}

		# You can override heuristics with SPFLAGS, these must always go last
		OPTIONS="$OPTIONS $SPFLAGS"

		coccinelle () {
		COCCI="$1"

Admin message