Commit 8e7b3410 authored Jan 06, 2015 by Jiri Kosina

HID: fixup the conflicting keyboard mappings quirk



The ignore check that got added in 6ce901eb ("HID: input: fix confusion
on conflicting mappings") needs to properly check for VARIABLE reports
as well (ARRAY reports should be ignored), otherwise legitimate keyboards
might break.

Cc: <stable@vger.kernel.org>
Fixes: 6ce901eb ("HID: input: fix confusion on conflicting mappings")
Reported-by: Fredrik Hallenberg <megahallon@gmail.com>
Reported-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 79bc33bd

drivers/hid/hid-input.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1113,6 +1113,7 @@ void hidinput_hid_event(struct hid_device hid, struct hid_field field, struct
		*/
		if (!(field->flags & (HID_MAIN_ITEM_RELATIVE \|
		HID_MAIN_ITEM_BUFFERED_BYTE)) &&
		(field->flags & HID_MAIN_ITEM_VARIABLE) &&
		usage->usage_index < field->maxusage &&
		value == field->value[usage->usage_index])
		return;

Admin message