Commit 8e58caef authored Nov 23, 2013 by Grygorii Strashko Committed by Santosh Shilimkar Nov 23, 2013

ARM: mm: Don't allow resizing of memblock data until "low" memory is not mapped



If allowed by call to memblock_allow_resize() - The Memblock core will
try to allocate additional memory and rearrange its internal data in
case, if there are more then INIT_MEMBLOCK_REGIONS(128) memory regions
of any type have been allocated. If this happens before Low memory is
mapped (which is done now by map_lowmem()) the system will hang, because
the Memblock core will try to operate with virtual addresses which
aren't mapped yet.

In ARM code, the memblock resizing is allowed (memblock_allow_resize())
from arm_memblock_init() which is called before map_lowmem(), so
this may lead to an error as described above.

Hence, allow Memblock resizing later during init, from bootmem_init()
when all appropriate mappings are ready.

Cc: Russell King <linux@arm.linux.org.uk>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

parent b3ba41f2

arch/arm/mm/init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -384,7 +384,6 @@ void __init arm_memblock_init(struct meminfo *mi,
		dma_contiguous_reserve(min(arm_dma_limit, arm_lowmem_limit));

		arm_memblock_steal_permitted = false;
		memblock_allow_resize();
		memblock_dump_all();
		}

		@@ -392,6 +391,7 @@ void __init bootmem_init(void)
		{
		unsigned long min, max_low, max_high;

		memblock_allow_resize();
		max_low = max_high = 0;

		find_limits(&min, &max_low, &max_high);

Admin message