Commit 8e4fefec authored Apr 10, 2019 by Colin Ian King Committed by Jonathan Cameron Apr 14, 2019

iio: temperature: max31856: fix uninitialized error return



Currently if mask is neither CHAN_INFO_RAW or CHAN_INFO_SCALE then
then an uninitialized error return 'ret' is returned. Fix this by
adding a default case that ensures -EINVAL is returned for this
specific case.

Addresses-Coverity: ("Uninitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 631bd2f7

drivers/iio/temperature/max31856.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -210,6 +210,9 @@ static int max31856_read_raw(struct iio_dev *indio_dev,
		return IIO_VAL_INT_PLUS_MICRO;
		}
		break;
		default:
		ret = -EINVAL;
		break;
		}

		return ret;

Admin message