Commit 8e4efd47 authored Aug 25, 2020 by Sumera Priyadarsini Committed by David S. Miller Aug 25, 2020

net: dsa: mt7530: Add of_node_put() before break and return statements



Every iteration of for_each_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in mt7530.c by inserting of_node_put()
before the break and return statements.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b274e47d

drivers/net/dsa/mt7530.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1326,14 +1326,17 @@ mt7530_setup(struct dsa_switch *ds)

		if (phy_node->parent == priv->dev->of_node->parent) {
		ret = of_get_phy_mode(mac_np, &interface);
		if (ret && ret != -ENODEV)
		if (ret && ret != -ENODEV) {
		of_node_put(mac_np);
		return ret;
		}
		id = of_mdio_parse_addr(ds->dev, phy_node);
		if (id == 0)
		priv->p5_intf_sel = P5_INTF_SEL_PHY_P0;
		if (id == 4)
		priv->p5_intf_sel = P5_INTF_SEL_PHY_P4;
		}
		of_node_put(mac_np);
		of_node_put(phy_node);
		break;
		}

Admin message