Commit 8e4c309f authored May 08, 2020 by Sascha Hauer Committed by Jens Axboe Oct 28, 2020

ata: sata_nv: Fix retrieving of active qcs



ata_qc_complete_multiple() has to be called with the tags physically
active, that is the hw tag is at bit 0. ap->qc_active has the same tag
at bit ATA_TAG_INTERNAL instead, so call ata_qc_get_active() to fix that
up. This is done in the vein of 8385d756 ("libata: Fix retrieving of
active qcs").

Fixes: 28361c40 ("libata: add extra internal command")
Tested-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 94bd5719

drivers/ata/sata_nv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2100,7 +2100,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
		pp->dhfis_bits &= ~done_mask;
		pp->dmafis_bits &= ~done_mask;
		pp->sdbfis_bits \|= done_mask;
		ata_qc_complete_multiple(ap, ap->qc_active ^ done_mask);
		ata_qc_complete_multiple(ap, ata_qc_get_active(ap) ^ done_mask);

		if (!ap->qc_active) {
		DPRINTK("over\n");

Admin message