Commit 8e47567f authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: cx231xx: improve error handling 



Return -EINVAL if we don't find the control id.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent f7628015

drivers/media/video/cx231xx/cx231xx-video.c

+4 −1
Original line number Diff line number Diff line
@@ -1902,9 +1902,12 @@ static int radio_queryctrl(struct file *file, void *priv, 
	if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)

		return -EINVAL;

	if (c->id == V4L2_CID_AUDIO_MUTE) {

		for (i = 0; i < CX231XX_CTLS; i++)

		for (i = 0; i < CX231XX_CTLS; i++) {

			if (cx231xx_ctls[i].v.id == c->id)

				break;

		}

		if (i == CX231XX_CTLS)

			return -EINVAL;

		*c = cx231xx_ctls[i].v;

	} else

		*c = no_ctl;

CRA Git | Maintained and supported by SUSTech CRA and CCSE