Commit 8e27c2ae authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: exar: switch to a simpler IDA interface 



We don't need to specify any ranges when allocating IDs so we can switch
to ida_alloc() and ida_free() instead of the ida_simple_ counterparts.

ida_simple_get(ida, 0, 0, gfp) is equivalent to
ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to
ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID
larger than INT_MAX.

Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 26ced453

drivers/gpio/gpio-exar.c

+3 −3
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ static int gpio_exar_probe(struct platform_device *pdev) 


	mutex_init(&exar_gpio->lock);



	index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);

	index = ida_alloc(&ida_index, GFP_KERNEL);

	if (index < 0) {

		ret = index;

		goto err_mutex_destroy;
@@ -179,7 +179,7 @@ static int gpio_exar_probe(struct platform_device *pdev) 
	return 0;



err_destroy:

	ida_simple_remove(&ida_index, index);

	ida_free(&ida_index, index);

err_mutex_destroy:

	mutex_destroy(&exar_gpio->lock);

	return ret;
@@ -189,7 +189,7 @@ static int gpio_exar_remove(struct platform_device *pdev) 
{

	struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev);



	ida_simple_remove(&ida_index, exar_gpio->index);

	ida_free(&ida_index, exar_gpio->index);

	mutex_destroy(&exar_gpio->lock);



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE