Commit 8e138e0d authored Nov 17, 2017 by Josef Bacik Committed by David Sterba Nov 20, 2017

btrfs: clear space cache inode generation always



We discovered a box that had double allocations, and suspected the space
cache may be to blame.  While auditing the write out path I noticed that
if we've already setup the space cache we will just carry on.  This
means that any error we hit after cache_save_setup before we go to
actually write the cache out we won't reset the inode generation, so
whatever was already written will be considered correct, except it'll be
stale.  Fix this by _always_ resetting the generation on the block group
inode, this way we only ever have valid or invalid cache.

With this patch I was no longer able to reproduce cache corruption with
dm-log-writes and my bpf error injection tool.

Cc: stable@vger.kernel.org
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent e3b8a485

fs/btrfs/extent-tree.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -3502,13 +3502,6 @@ again:
		goto again;
		}

		/* We've already setup this transaction, go ahead and exit */
		if (block_group->cache_generation == trans->transid &&
		i_size_read(inode)) {
		dcs = BTRFS_DC_SETUP;
		goto out_put;
		}

		/*
		* We want to set the generation to 0, that way if anything goes wrong
		* from here on out we know not to trust this cache when we load up next
		@@ -3532,6 +3525,13 @@ again:
		}
		WARN_ON(ret);

		/* We've already setup this transaction, go ahead and exit */
		if (block_group->cache_generation == trans->transid &&
		i_size_read(inode)) {
		dcs = BTRFS_DC_SETUP;
		goto out_put;
		}

		if (i_size_read(inode) > 0) {
		ret = btrfs_check_trunc_cache_free_space(fs_info,
		&fs_info->global_block_rsv);

Admin message