Commit 8e13059a authored by Akinobu Mita's avatar Akinobu Mita Committed by Linus Torvalds
Browse files

[PATCH] use list_add_tail() instead of list_add() 



This patch converts list_add(A, B.prev) to list_add_tail(A, &B) for
readability.

Acked-by: default avatarKarsten Keil <kkeil@suse.de>
Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Acked-by: default avatarJan Kara <jack@suse.cz>
AOLed-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
Cc: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: default avatarAkinobu Mita <mita@miraclelinux.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 38e13929

fs/coda/psdev.c

+1 −1
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ static ssize_t coda_psdev_read(struct file * file, char __user * buf, 
	/* If request was not a signal, enqueue and don't free */

	if (!(req->uc_flags & REQ_ASYNC)) {

		req->uc_flags |= REQ_READ;

		list_add(&(req->uc_chain), vcp->vc_processing.prev);

		list_add_tail(&(req->uc_chain), &vcp->vc_processing);

		goto out;

	}

fs/coda/upcall.c

+1 −1
Original line number Diff line number Diff line
@@ -725,7 +725,7 @@ static int coda_upcall(struct coda_sb_info *sbi, 
	((union inputArgs *)buffer)->ih.unique = req->uc_unique;



	/* Append msg to pending queue and poke Venus. */

	list_add(&(req->uc_chain), vcommp->vc_pending.prev);

	list_add_tail(&(req->uc_chain), &vcommp->vc_pending);

        

	wake_up_interruptible(&vcommp->vc_waitq);

	/* We can be interrupted while we wait for Venus to process

fs/dcache.c

+1 −1
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ resume: 
		 * of the unused list for prune_dcache

		 */

		if (!atomic_read(&dentry->d_count)) {

			list_add(&dentry->d_lru, dentry_unused.prev);

			list_add_tail(&dentry->d_lru, &dentry_unused);

			dentry_stat.nr_unused++;

			found++;

		}

fs/dquot.c

+2 −2
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ static inline struct dquot *find_dquot(unsigned int hashent, struct super_block 
/* Add a dquot to the tail of the free list */

static inline void put_dquot_last(struct dquot *dquot)

{

	list_add(&dquot->dq_free, free_dquots.prev);

	list_add_tail(&dquot->dq_free, &free_dquots);

	dqstats.free_dquots++;

}
@@ -266,7 +266,7 @@ static inline void put_inuse(struct dquot *dquot) 
{

	/* We add to the back of inuse list so we don't have to restart

	 * when traversing this list and we block */

	list_add(&dquot->dq_inuse, inuse_list.prev);

	list_add_tail(&dquot->dq_inuse, &inuse_list);

	dqstats.allocated_dquots++;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE