Commit 8df955a3 authored Dec 30, 2019 by Kees Cook

pstore/ram: Fix error-path memory leak in persistent_ram_new() callers



For callers that allocated a label for persistent_ram_new(), if the call
fails, they must clean up the allocation.

Suggested-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Fixes: 1227daa4 ("pstore/ram: Clarify resource reservation labels")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/lkml/20191211191353.14385-1-navid.emamdoost@gmail.com


Signed-off-by: Kees Cook <keescook@chromium.org>

parent d1eef1c6

fs/pstore/ram.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -577,6 +577,7 @@ static int ramoops_init_przs(const char *name,
		dev_err(dev, "failed to request %s mem region (0x%zx@0x%llx): %d\n",
		name, record_size,
		(unsigned long long)*paddr, err);
		kfree(label);

		while (i > 0) {
		i--;
		@@ -622,6 +623,7 @@ static int ramoops_init_prz(const char *name,

		dev_err(dev, "failed to request %s mem region (0x%zx@0x%llx): %d\n",
		name, sz, (unsigned long long)*paddr, err);
		kfree(label);
		return err;
		}

Admin message