Commit 8df92d67 authored Aug 04, 2019 by Nishka Dasgupta Committed by Linus Walleij Aug 06, 2019

pinctrl: spear: spear: Add of_node_put() before return



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20190804154948.4584-1-nishkadg.linux@gmail.com


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 646d90c3

drivers/pinctrl/spear/pinctrl-spear.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -157,12 +157,16 @@ static int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
		/* calculate number of maps required */
		for_each_child_of_node(np_config, np) {
		ret = of_property_read_string(np, "st,function", &function);
		if (ret < 0)
		if (ret < 0) {
		of_node_put(np);
		return ret;
		}

		ret = of_property_count_strings(np, "st,pins");
		if (ret < 0)
		if (ret < 0) {
		of_node_put(np);
		return ret;
		}

		count += ret;
		}

Admin message