Commit 8df52620 authored by Sam Ravnborg's avatar Sam Ravnborg Committed by David S. Miller
Browse files

sparc64: fix sparse warnings in sys_sparc_64.c + unaligned_64.c 



Fix following warnings:
kernel/sys_sparc_64.c:643:17: warning: symbol 'sys_kern_features' was not declared. Should it be static?
kernel/unaligned_64.c:297:17: warning: symbol 'kernel_unaligned_trap' was not declared. Should it be static?
kernel/unaligned_64.c:387:5: warning: symbol 'handle_popc' was not declared. Should it be static?
kernel/unaligned_64.c:428:5: warning: symbol 'handle_ldf_stq' was not declared. Should it be static?
kernel/unaligned_64.c:553:6: warning: symbol 'handle_ld_nf' was not declared. Should it be static?
kernel/unaligned_64.c:579:6: warning: symbol 'handle_lddfmna' was not declared. Should it be static?
kernel/unaligned_64.c:643:6: warning: symbol 'handle_stdfmna' was not declared. Should it be static?

Functions that are only used in kernel/ - add prototypes in kernel.h
Functions used outside kernel/ - add prototype in asm/setup.h
Removed local prototypes

One of the local prototypes had wrong signature (return void - not int).

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d1584504

arch/sparc/include/asm/setup.h

+7 −0
Original line number Diff line number Diff line
@@ -47,6 +47,13 @@ unsigned long safe_compute_effective_address(struct pt_regs *, unsigned int); 


#endif



#ifdef CONFIG_SPARC64

/* unaligned_64.c */

int handle_ldf_stq(u32 insn, struct pt_regs *regs);

void handle_ld_nf(u32 insn, struct pt_regs *regs);



#endif



void sun_do_break(void);

extern int stop_a_enabled;

extern int scons_pwroff;

arch/sparc/kernel/kernel.h

+10 −0
Original line number Diff line number Diff line
@@ -23,6 +23,16 @@ static inline unsigned long kimage_addr_to_ra(const char *p) 


	return kern_base + (val - KERNBASE);

}



/* sys_sparc_64.c */

asmlinkage long sys_kern_features(void);



/* unaligned_64.c */

asmlinkage void kernel_unaligned_trap(struct pt_regs *regs, unsigned int insn);

int handle_popc(u32 insn, struct pt_regs *regs);

void handle_lddfmna(struct pt_regs *regs, unsigned long sfar, unsigned long sfsr);

void handle_stdfmna(struct pt_regs *regs, unsigned long sfar, unsigned long sfsr);



#endif



#ifdef CONFIG_SPARC32

arch/sparc/kernel/sys_sparc_64.c

+1 −0
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ 
#include <asm/unistd.h>



#include "entry.h"

#include "kernel.h"

#include "systbls.h"



/* #define DEBUG_UNIMP_SYSCALL */

arch/sparc/kernel/traps_64.c

+2 −5
Original line number Diff line number Diff line
@@ -43,8 +43,10 @@ 
#include <asm/prom.h>

#include <asm/memctrl.h>

#include <asm/cacheflush.h>

#include <asm/setup.h>



#include "entry.h"

#include "kernel.h"

#include "kstack.h"



/* When an irrecoverable trap occurs at tl > 0, the trap entry
@@ -2431,9 +2433,6 @@ EXPORT_SYMBOL(die_if_kernel); 
#define VIS_OPCODE_MASK	((0x3 << 30) | (0x3f << 19))

#define VIS_OPCODE_VAL	((0x2 << 30) | (0x36 << 19))



extern int handle_popc(u32 insn, struct pt_regs *regs);

extern int handle_ldf_stq(u32 insn, struct pt_regs *regs);



void do_illegal_instruction(struct pt_regs *regs)

{

	enum ctx_state prev_state = exception_enter();
@@ -2484,8 +2483,6 @@ out: 
	exception_exit(prev_state);

}



extern void kernel_unaligned_trap(struct pt_regs *regs, unsigned int insn);



void mem_address_unaligned(struct pt_regs *regs, unsigned long sfar, unsigned long sfsr)

{

	enum ctx_state prev_state = exception_enter();

arch/sparc/kernel/unaligned_64.c

+2 −0
Original line number Diff line number Diff line
@@ -24,8 +24,10 @@ 
#include <linux/context_tracking.h>

#include <asm/fpumacro.h>

#include <asm/cacheflush.h>

#include <asm/setup.h>



#include "entry.h"

#include "kernel.h"



enum direction {

	load,    /* ld, ldd, ldh, ldsh */

CRA Git | Maintained and supported by SUSTech CRA and CCSE