Commit 8ddbda76 authored Mar 03, 2020 by Srinivas Pandruvada Committed by Andy Shevchenko Mar 20, 2020

tools/power/x86/intel-speed-select: Fix mailbox usage for CLOS_PM_QOS_CONFIG

Even for the products using MMIO, this message needs to be sent via
mail box. The previous fix done for this didn't properly address this.
That fix simply removed sending command via MMIO, but still didn't
trigger sending via mailbox.

Add additional condition to check for CLOS_PM_QOS_CONFIG, when MMIO
is supported on a platform.

Fixes: cd0e6370 (tools/power/x86/intel-speed-select: Use mailbox for CLOS_PM_QOS_CONFIG)
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent b40e288b

tools/power/x86/intel-speed-select/isst-config.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -572,7 +572,8 @@ int isst_send_mbox_command(unsigned int cpu, unsigned char command,
		"mbox_send: cpu:%d command:%x sub_command:%x parameter:%x req_data:%x\n",
		cpu, command, sub_command, parameter, req_data);

		if (isst_platform_info.mmio_supported && command == CONFIG_CLOS) {
		if (isst_platform_info.mmio_supported && command == CONFIG_CLOS &&
		sub_command != CLOS_PM_QOS_CONFIG) {
		unsigned int value;
		int write = 0;
		int clos_id, core_id, ret = 0;

Admin message