Unverified Commit 8db06423 authored Dec 07, 2020 by Dan Carpenter Committed by Mark Brown Dec 08, 2020

regulator: da9121: Potential Oops in da9121_assign_chip_model()



There is a missing "return ret;" on this error path so we call
"da9121_check_device_type(i2c, chip);" which will end up dereferencing
"chip->regmap" and lead to an Oops.

Fixes: c860476b ("regulator: da9121: Add device variant regmaps")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Adam Ward <Adam.Ward.opensource@diasemi.com>
Link: https://lore.kernel.org/r/X85soGKnWAjPUA7a@mwanda


Signed-off-by: Mark Brown <broonie@kernel.org>

parent bebb2c6d

drivers/regulator/da9121-regulator.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -915,6 +915,7 @@ static int da9121_assign_chip_model(struct i2c_client *i2c,
		ret = PTR_ERR(chip->regmap);
		dev_err(chip->dev, "Failed to configure a register map: %d\n",
		ret);
		return ret;
		}

		ret = da9121_check_device_type(i2c, chip);

Admin message