Commit 8daf1a2d authored Mar 26, 2018 by Colin Ian King Committed by David S. Miller Mar 27, 2018

net/ncsi: check for null return from call to nla_nest_start



The call to nla_nest_start calls nla_put which can lead to a NULL
return so it's possible for attr to become NULL and we can potentially
get a NULL pointer dereference on attr.  Fix this by checking for
a NULL return.

Detected by CoverityScan, CID#1466125 ("Dereference null return")

Fixes: 955dc68c ("net/ncsi: Add generic netlink family")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 53066538

net/ncsi/ncsi-netlink.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -190,6 +190,10 @@ static int ncsi_pkg_info_nl(struct sk_buff msg, struct genl_info info)
		package_id = nla_get_u32(info->attrs[NCSI_ATTR_PACKAGE_ID]);

		attr = nla_nest_start(skb, NCSI_ATTR_PACKAGE_LIST);
		if (!attr) {
		kfree_skb(skb);
		return -EMSGSIZE;
		}
		rc = ncsi_write_package_info(skb, ndp, package_id);

		if (rc) {

Admin message