Commit 8daee952 authored Mar 12, 2020 by Wolfram Sang Committed by Wolfram Sang Mar 13, 2020

i2c: acpi: put device when verifying client fails



i2c_verify_client() can fail, so we need to put the device when that
happens.

Fixes: 525e6fab ("i2c / ACPI: add support for ACPI reconfigure notifications")
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent 3747cd2e

drivers/i2c/i2c-core-acpi.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -394,9 +394,17 @@ EXPORT_SYMBOL_GPL(i2c_acpi_find_adapter_by_handle);
		static struct i2c_client i2c_acpi_find_client_by_adev(struct acpi_device adev)
		{
		struct device *dev;
		struct i2c_client *client;

		dev = bus_find_device_by_acpi_dev(&i2c_bus_type, adev);
		return dev ? i2c_verify_client(dev) : NULL;
		if (!dev)
		return NULL;

		client = i2c_verify_client(dev);
		if (!client)
		put_device(dev);

		return client;
		}

		static int i2c_acpi_notify(struct notifier_block *nb, unsigned long value,

Admin message