[S390] Improve __smp_call_function_map. (8da1aecd) · Commits · 戴 / test

There is no need to disable bottom halves when holding call_lock. Also this could imply that it is legal to call smp_call_function* from bh context, which it is not. Also test if func will be executed locally before disabling and aterwards enabling interrupts again. It's not necessary to disable and enable interrupts each time __smp_call_function_map gets called. Signed-off-by:

Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:

Martin Schwidefsky <schwidefsky@de.ibm.com>

arch/s390/kernel/smp.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -120,7 +120,7 @@ static void __smp_call_function_map(void (func) (void info), void *info,
		if (wait)
		data.finished = CPU_MASK_NONE;

		spin_lock_bh(&call_lock);
		spin_lock(&call_lock);
		call_data = &data;

		for_each_cpu_mask(cpu, map)
		@@ -129,19 +129,17 @@ static void __smp_call_function_map(void (func) (void info), void *info,
		/* Wait for response */
		while (!cpus_equal(map, data.started))
		cpu_relax();

		if (wait)
		while (!cpus_equal(map, data.finished))
		cpu_relax();

		spin_unlock_bh(&call_lock);

		spin_unlock(&call_lock);
		out:
		if (local) {
		local_irq_disable();
		if (local)
		func(info);
		local_irq_enable();
		}
		}

		/*
		* smp_call_function:

Admin message