Commit 8d972a96 authored by Russell King's avatar Russell King Committed by Russell King
Browse files

[DRIVER MODEL] Fix arcfb 



Release code in driver modules is a potential cause of oopsen.
The device may be in use by a userspace process, which will keep
a reference to the device.  If the module is unloaded, the module
text will be freed.  Subsequently, when the last reference is
dropped, the release code will be called, which no longer exists.

Use generic platform device allocation/release code in modules.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 09c6518c

drivers/video/arcfb.c

+11 −14
Original line number Diff line number Diff line
@@ -502,10 +502,6 @@ static ssize_t arcfb_write(struct file *file, const char *buf, size_t count, 
	return err;

}



static void arcfb_platform_release(struct device *device)

{

}



static struct fb_ops arcfb_ops = {

	.owner		= THIS_MODULE,

	.fb_open	= arcfb_open,
@@ -624,13 +620,7 @@ static struct device_driver arcfb_driver = { 
	.remove = arcfb_remove,

};



static struct platform_device arcfb_device = {

	.name	= "arcfb",

	.id	= 0,

	.dev	= {

		.release = arcfb_platform_release,

	}

};

static struct platform_device *arcfb_device;



static int __init arcfb_init(void)

{
@@ -641,17 +631,24 @@ static int __init arcfb_init(void) 


	ret = driver_register(&arcfb_driver);

	if (!ret) {

		ret = platform_device_register(&arcfb_device);

		if (ret)

		arcfb_device = platform_device_alloc("arcfb", 0);

		if (arcfb_device) {

			ret = platform_device_add(arcfb_device);

		} else {

			ret = -ENOMEM;

		}

		if (ret) {

			platform_device_put(arcfb_device);

			driver_unregister(&arcfb_driver);

		}

	}

	return ret;



}



static void __exit arcfb_exit(void)

{

	platform_device_unregister(&arcfb_device);

	platform_device_unregister(arcfb_device);

	driver_unregister(&arcfb_driver);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE