Commit 8d95ab34 authored Aug 20, 2020 by Dinghao Liu Committed by Kalle Valo Aug 27, 2020

wilc1000: Fix memleak in wilc_sdio_probe



When devm_clk_get() returns -EPROBE_DEFER, sdio_priv
should be freed just like when wilc_cfg80211_init()
fails.

Fixes: 8692b047 ("staging: wilc1000: look for rtc_clk clock")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200820054819.23365-1-dinghao.liu@zju.edu.cn

parent 621a3a8b

drivers/net/wireless/microchip/wilc1000/sdio.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -149,9 +149,10 @@ static int wilc_sdio_probe(struct sdio_func *func,
		wilc->dev = &func->dev;

		wilc->rtc_clk = devm_clk_get(&func->card->dev, "rtc");
		if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER)
		if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER) {
		kfree(sdio_priv);
		return -EPROBE_DEFER;
		else if (!IS_ERR(wilc->rtc_clk))
		} else if (!IS_ERR(wilc->rtc_clk))
		clk_prepare_enable(wilc->rtc_clk);

		dev_info(&func->dev, "Driver Initializing success\n");

Admin message